Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added ones, full, empty_like, zeros_like, ones_like and full_like ctors #822

Merged
merged 4 commits into from
Apr 26, 2022
Merged

Added ones, full, empty_like, zeros_like, ones_like and full_like ctors #822

merged 4 commits into from
Apr 26, 2022

Conversation

oleksandr-pavlyk
Copy link
Collaborator

Added ones, full and empty_like, ones_like, zeros_like and full_like implementations.

Default dtype changed from "f8" to None per spec.

@github-actions
Copy link

View rendered docs @ https://intelpython.github.io/dpctl/pulls/822/index.html

@coveralls
Copy link
Collaborator

coveralls commented Apr 26, 2022 •
edited
Loading

Coverage Status

Coverage increased (+0.2%) to 82.918% when pulling dc7aa6c on ones_full_and_like into 77e6a60 on master.

@oleksandr-pavlyk
Fixed error in arange shape computation
4c9d413 
dpt.arange(4, 0, -1) was producing array of wrong size.
Bug fixed, test to be added.
@oleksandr-pavlyk
Expanded tests
6f6916e 
1. Added test for arange with negative step
2. Added tests for empty_like, zeros_like, ones_like, full_like
@oleksandr-pavlyk
Added arg validation tests for some constructors
dc7aa6c
@oleksandr-pavlyk oleksandr-pavlyk marked this pull request as ready for review April 26, 2022 21:07
@oleksandr-pavlyk oleksandr-pavlyk merged commit 22d231c into master Apr 26, 2022
@oleksandr-pavlyk oleksandr-pavlyk deleted the ones_full_and_like branch April 26, 2022 21:08
@github-actions
Copy link

Deleted rendered PR docs from intelpython.github.com/dpctl, latest should be updated shortly. 🤞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@oleksandr-pavlyk @coveralls